Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHS Compat Enhancement for Weapons and Grenades #3045

Merged
merged 2 commits into from
Dec 31, 2015
Merged

RHS Compat Enhancement for Weapons and Grenades #3045

merged 2 commits into from
Dec 31, 2015

Conversation

sargken
Copy link
Contributor

@sargken sargken commented Dec 17, 2015

The RHS M249 and M240 now have the overheating and change barrel, plus
the M4 and M16 branch should have overheating applied to them. The ammo
class should have all of the hand grenade fixes in there.

The RHS M249 and M240 now have the overheating and change barrel, plus
the M4 and M16 branch should have overheating applied to them. The ammo
class should have all of the hand grenade fixes in there.
@sargken sargken changed the title RHS weapons and Frag update RHS Compat Enhancement for Weapons and Grenades Dec 17, 2015
ace_frag_force = 1;
};
class rhs_rpg7v2_tbg7v: rhs_rpg7v2_pg7vl {
ace_frag_enabled = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you disable here Fraging?

Same for rhs_rshg2_rocket

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBG-7V is Thermobaric

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got permission from this mod author to add this in.
https://forums.bistudio.com/topic/185587-ace3xrhs-fragmentation-configs/
its a carbon copy of the fragmentation portion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3045 (comment)
didnt know that thanks for the information

@sargken
Copy link
Contributor Author

sargken commented Dec 17, 2015

@MikeMatrix I hope this looks better than this #3012

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Dec 18, 2015

class GrenadeHand;
class rhs_ammo_rgd5: GrenadeHand {
ace_frag_enabled = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another tab is still here.

@MikeMatrix
Copy link
Contributor

Looks good.
👍 if you fix the few remaining tabs that are in this PR.
(Recommendation to use an editor like Atom or Sublime Text to make your edits. They have options to which style of tab indentation you want to use, as well as conversion methods from one style to another.)

@bux
Copy link
Member

bux commented Dec 18, 2015

They have options to which style of tab indentation you want to use, as well as conversion methods from one style to another.

And there's the .editorconfig file in ACE3's root.

@sargken
Copy link
Contributor Author

sargken commented Dec 18, 2015

Ok sounds good and you guys are deadly with those tabs.

@VKing6
Copy link
Member

VKing6 commented Dec 18, 2015

Is this fixing the fragmentation issue with the RGN grenades? And if so, could you add the same for the RGO grenade?

ACE_Overheating_allowSwapBarrel = 1;
ACE_Overheating_Dispersion[] = {0, -0.001, 0.001, 0.003};
ACE_Overheating_SlowdownFactor[] = {1, 1, 1, 0.9};
ACE_Overheating_JamChance[] = {0, 0.0003, 0.0015, 0.0075};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone know if the overheating config is setup properly. I put 500 rounds through the gun and it didnt get hot at all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably is; there's a bug in overheating atm. Ref #2978

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thx.

PabstMirror added a commit that referenced this pull request Dec 31, 2015
RHS Compat Enhancement for Weapons and Grenades
@PabstMirror PabstMirror merged commit 8ac3a09 into acemod:master Dec 31, 2015
@PabstMirror PabstMirror added this to the 3.4.2 milestone Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants